version 2.8

diff --git a/ChangeLog b/ChangeLog
index 3dcc785913c2dae9effe82859639642bf836a11f..141c98f11dba6b5371ef5cf17f80faf435f83b06 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,6 +1,8 @@
-version 2.8 - Wastelands ()
+version 2.8 - Wastelands (2022-12-10)
 
        + Fixed documentation
+       + Fixed some PHP 8 defaults
+       + Fixed #17
 
 version 2.7 - Sacred Grove (2022-06-12)
 

diff --git a/documentation/requirements.txt b/documentation/requirements.txt
index a5aa9ffd7223e4cbae1a738887e6c08fe7fc21ad..942a27e57b2821337eb99c25c1bdb934f5268a7d 100644 (file)
--- a/documentation/requirements.txt
+++ b/documentation/requirements.txt
@@ -1,13 +1,13 @@
 Apache (2.4 and up) with PHP extension enabled
-PHP (7 and up)
+PHP (8 and up)
 - mysql & mysqli
 - curl
 - pdo
 - imap +ssl if you us the email importer
 - xmlread
 - xmlwriter
-MySQL server or access to database 5.6.x and up
+MySQL server or access to a database 5.6.x and up
 - DB user rights has to include create, alter a view
 - NOT MariaDB. It is missing some functions MySQL has.
 
-Latest browser for accessing the client. IE (not Edge) is not supported anymore.
\ No newline at end of file
+Latest browser for accessing the client. IE (not Edge) is not supported anymore.

diff --git a/documentation/update.txt b/documentation/update.txt
index 5b9a9ede69ccd4e6453d305b5feb586b3b48d13b..fe7d00ef828ddf810e757bc7b60583102f7bb9e2 100644 (file)
--- a/documentation/update.txt
+++ b/documentation/update.txt
@@ -1,25 +1,25 @@
 If you are updating from a previous version make sure every update info from
 the version your are updating from is done.
 
+## version 2.8 Wastelands
++ Nothing.
+
 ## version 2.7 Sacred Grove
 + New syntax in config file. Switched from define() to const syntax.
   Use config.default.php as a template to update your config.
 
 ## version 2.6 - Hypostyle
-
 + Update config file with the new language setting. See config.default and
   translation.txt for more information
 + Run update search index to use the URL within the search index for your existing data.
 
 ## version 2.5 - Winnowing Hall
-
 + Update config file with the two new constants. See config.default and
   snapshots-of-linked-webpage.txt for more information
   define('WKHTMLTOPDF_USE',false);
   define('WKHTMLTOPDF_COMMAND','/absolute/path/to/wkhtmltoimage');
 
 ## version 2.4 - Seven Portals (2020-02-16)
-
 + Run (after authentication) at /index.php?p=stats the "Search index update"
   to make the search work again correctly. At success, there is no confirmation.
   To validate you can now search for single words case-insensitive.

diff --git a/webroot/index.php b/webroot/index.php
index 760218327607d4930d1516887440ba32092001d2..3ec1842ac32e7c995b36f8934af9a8bd553efabf 100644 (file)
--- a/webroot/index.php
+++ b/webroot/index.php
@@ -32,7 +32,7 @@ ini_set('error_reporting',-1); // E_ALL & E_STRICT
 # time settings
 date_default_timezone_set('Europe/Berlin');
 
-define('DEBUG',true);
+define('DEBUG',false);
 
 ## check request
 $_urlToParse = filter_var($_SERVER['QUERY_STRING'],FILTER_UNSAFE_RAW, FILTER_FLAG_STRIP_LOW);

diff --git a/webroot/lib/category.class.php b/webroot/lib/category.class.php
index e84b226f674c1ad26261b74e1a7f0dfe15bd577b..6e5f2da1d578df92767dbfb872f13e2634c23476 100644 (file)
--- a/webroot/lib/category.class.php
+++ b/webroot/lib/category.class.php
@@ -29,7 +29,7 @@
 class Category {
        /**
         * the database object
-        * @var object
+        * @var mysqli
         */
        private $DB;
 
@@ -56,7 +56,7 @@ class Category {
         * @param bool $doNotCreate
         * @return int 0=fail, 1=existing, 2=new, 3=newNotCreated
         */
-    public function initbystring(string $string, $doNotCreate=false): int {
+    public function initbystring(string $string, bool $doNotCreate=false): int {
         $ret = 0;
                $this->_id = false;
         if(!empty($string)) {
@@ -119,7 +119,7 @@ class Category {
         * @param bool $key
         * @return string
         */
-       public function getData($key=false): string {
+       public function getData(bool $key=false): string {
                $ret = $this->_data;
 
                if(!empty($key) && isset($this->_data[$key])) {

diff --git a/webroot/lib/email-import-helper.class.php b/webroot/lib/email-import-helper.class.php
index 97d80ab77e172d57be29a0d03e6990fdfedfe5a7..0e403aed5a4ee9f8b0b6a7d589dab344a8cde756 100644 (file)
--- a/webroot/lib/email-import-helper.class.php
+++ b/webroot/lib/email-import-helper.class.php
@@ -3,7 +3,7 @@
  * Insipid
  * Personal web-bookmark-system
  *
- * Copyright 2016-2021 Johannes Keßler
+ * Copyright 2016-2022 Johannes Keßler
  *
  * Development starting from 2011: Johannes Keßler
  * https://www.bananas-playground.net/projekt/insipid/
@@ -108,7 +108,6 @@ class EmailImportHelper {
                        || isset($headers['x-mailing-list'])
                        || isset($headers['list-unsubscribe'])
                        || isset($headers['list-owner'])
-                       || isset($headers['auto-submitted'])
                        || isset($headers['x-autoreply-from'])
                        || isset($headers['x-mail-autoreply'])
                        || isset($headers['x-mc-system'])

diff --git a/webroot/lib/link.class.php b/webroot/lib/link.class.php
index cb00a53b629ab1873101ac42853d41745f3bf153..38347cee605f252be759a2ba60d18d64f42f9953 100644 (file)
--- a/webroot/lib/link.class.php
+++ b/webroot/lib/link.class.php
@@ -34,7 +34,7 @@ class Link {
        /**
         * the database object
         *
-        * @var Object
+        * @var mysqli
         */
        private $DB;
 
@@ -48,10 +48,10 @@ class Link {
        /**
         * Link constructor.
         *
-        * @param Object $databaseConnectionObject
+        * @param mysqli $databaseConnectionObject
         * @return void
         */
-       public function __construct($databaseConnectionObject) {
+       public function __construct(mysqli $databaseConnectionObject) {
                $this->DB = $databaseConnectionObject;
        }
 

diff --git a/webroot/lib/management.class.php b/webroot/lib/management.class.php
index 56ad8ebc05a37a939a72fcbed976d99a21d2350e..bed89d9fc4519bbc8a7dc5242cb3334f0915d5f7 100644 (file)
--- a/webroot/lib/management.class.php
+++ b/webroot/lib/management.class.php
@@ -36,7 +36,7 @@ class Management {
        /**
         * the database object
         *
-        * @var object
+        * @var mysqli
         */
        private $DB;
 
@@ -51,10 +51,10 @@ class Management {
        /**
         * Management constructor.
         *
-        * @param Object $databaseConnectionObject
+        * @param mysqli $databaseConnectionObject
         * @return void
         */
-       public function __construct($databaseConnectionObject) {
+       public function __construct(mysqli $databaseConnectionObject) {
                $this->DB = $databaseConnectionObject;
        }
 

diff --git a/webroot/lib/summoner.class.php b/webroot/lib/summoner.class.php
index 2b4f88b9641d004f4729c0d3cffca4b8ec1f7516..3d036be71bbbe090556950b57925fac17b04da16 100644 (file)
--- a/webroot/lib/summoner.class.php
+++ b/webroot/lib/summoner.class.php
@@ -3,7 +3,7 @@
  * Insipid
  * Personal web-bookmark-system
  *
- * Copyright 2016-2021 Johannes Keßler
+ * Copyright 2016-2022 Johannes Keßler
  *
  * Development starting from 2011: Johannes Keßler
  * https://www.bananas-playground.net/projekt/insipid/
@@ -39,7 +39,7 @@ class Summoner {
         *
         * @param string $input The string to check
         * @param string $mode How the string should be checked
-        * @param mixed $limit If int given the string is checked for length
+        * @param int $limit If int given the string is checked for length
         *
         * @see http://de.php.net/manual/en/regexp.reference.unicode.php
         * http://www.sql-und-xml.de/unicode-database/#pc
@@ -50,7 +50,7 @@ class Summoner {
         *
         * @return bool
         */
-       static function validate($input,$mode='text',$limit=false): bool {
+       static function validate(string $input, string $mode='text', int $limit=0): bool {
                // check if we have input
                $input = trim($input);
 

diff --git a/webroot/lib/tag.class.php b/webroot/lib/tag.class.php
index d89c37563a5ec7d253735cf4e87c31a89d3a8efa..239ce02354aa312374addc919d924dc8e78b6f69 100644 (file)
--- a/webroot/lib/tag.class.php
+++ b/webroot/lib/tag.class.php
@@ -33,7 +33,7 @@ class Tag {
        /**
         * the database object
         *
-        * @var object
+        * @var mysqli
         */
        private $DB;
 
@@ -54,7 +54,7 @@ class Tag {
        /**
         * Tag constructor.
         *
-        * @param Obnject $databaseConnectionObject
+        * @param mysqli $databaseConnectionObject
         */
        public function __construct($databaseConnectionObject) {
                $this->DB = $databaseConnectionObject;